You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@kratzert , I downloaded and checked many stations visually, and I found some strange patterns sometimes:
It seems that either we have stations with years of 0 flow, or the API returns some 0s where it should be missing... It happened only in some basins, so as an advice, maybe it would be interesting to have a look before using it! I do not believe there are such cases of 0s, but trying to be the devils advocate, perhaps they have some very specific hydrology taking place in Korea? Anyway, I found it worth noting for you!
Ow, silly me, for sure it is needed the ids. Sorry Freddy. Here it goes some examples (for streamflow): 1018680 (from 2010 onwards), 1001605 (2013/2014), 1001607 (2015 onwards). For stage I did not get any issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to issue #72
Implements data fetcher for South Korea.
Includes: